ContiNew/continew-admin
1
1
Fork 0
mirror of https://github.com/continew-org/continew-admin.git synced 2025-09-13 14:57:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

优化：优化后端公共 CRUD 组件-修改接口，将 id 从请求体提取到路径变量，更符合 RESTful 风格

Browse Source
This commit is contained in:
Charles7c
2023-03-11 00:26:18 +08:00
parent 0d3f1ae633
commit 25e11ad9bc
17 changed files with 89 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
continew-admin-system/src/main/java/top/charles7c/cnadmin/system/service/impl/DeptServiceImpl.java
View File

@@ -61,7 +61,7 @@ public class DeptServiceImpl extends BaseServiceImpl<DeptMapper, DeptDO, DeptVO,
@Transactional(rollbackFor = Exception.class)
public Long add(DeptRequest request) {
String name = request.getName();
boolean isExists = this.checkNameExists(name, request.getParentId(), request.getId());
boolean isExists = this.checkNameExists(name, request.getParentId(), null);
CheckUtils.throwIf(() -> isExists, String.format("新增失败，'%s'已存在", name));
request.setStatus(DisEnableStatusEnum.ENABLE);
@@ -73,20 +73,20 @@ public class DeptServiceImpl extends BaseServiceImpl<DeptMapper, DeptDO, DeptVO,
@Override
@Transactional(rollbackFor = Exception.class)
public void update(DeptRequest request) {
public void update(DeptRequest request, Long id) {
String name = request.getName();
boolean isExists = this.checkNameExists(name, request.getParentId(), request.getId());
boolean isExists = this.checkNameExists(name, request.getParentId(), id);
CheckUtils.throwIf(() -> isExists, String.format("修改失败，'%s'已存在", name));
DeptDO oldDept = baseMapper.selectById(request.getId());
DeptDO oldDept = baseMapper.selectById(id);
// 更新祖级列表
if (!Objects.equals(oldDept.getParentId(), request.getParentId())) {
DeptDO newParentDept = baseMapper.selectById(request.getParentId());
CheckUtils.throwIfNull(newParentDept, "上级部门不存在");
request.setAncestors(String.format("%s,%s", newParentDept.getAncestors(), request.getParentId()));
this.updateChildrenAncestors(request.getId(), request.getAncestors(), oldDept.getAncestors());
this.updateChildrenAncestors(id, request.getAncestors(), oldDept.getAncestors());
}
super.update(request);
super.update(request, id);
}
@Override

8
continew-admin-system/src/main/java/top/charles7c/cnadmin/system/service/impl/MenuServiceImpl.java
View File

@@ -50,7 +50,7 @@ public class MenuServiceImpl extends BaseServiceImpl<MenuMapper, MenuDO, MenuVO,
@Transactional(rollbackFor = Exception.class)
public Long add(MenuRequest request) {
String title = request.getTitle();
boolean isExists = this.checkNameExists(title, request.getParentId(), request.getId());
boolean isExists = this.checkNameExists(title, request.getParentId(), null);
CheckUtils.throwIf(() -> isExists, String.format("新增失败，'%s'已存在", title));
request.setStatus(DisEnableStatusEnum.ENABLE);
@@ -59,12 +59,12 @@ public class MenuServiceImpl extends BaseServiceImpl<MenuMapper, MenuDO, MenuVO,
@Override
@Transactional(rollbackFor = Exception.class)
public void update(MenuRequest request) {
public void update(MenuRequest request, Long id) {
String title = request.getTitle();
boolean isExists = this.checkNameExists(title, request.getParentId(), request.getId());
boolean isExists = this.checkNameExists(title, request.getParentId(), id);
CheckUtils.throwIf(() -> isExists, String.format("修改失败，'%s'已存在", title));
super.update(request);
super.update(request, id);
}
@Override

17
continew-admin-system/src/main/java/top/charles7c/cnadmin/system/service/impl/RoleServiceImpl.java
View File

@@ -65,9 +65,9 @@ public class RoleServiceImpl extends BaseServiceImpl<RoleMapper, RoleDO, RoleVO,
@Transactional(rollbackFor = Exception.class)
public Long add(RoleRequest request) {
String name = request.getName();
CheckUtils.throwIf(() -> this.checkNameExists(name, request.getId()), String.format("新增失败，'%s'已存在", name));
CheckUtils.throwIf(() -> this.checkNameExists(name, null), String.format("新增失败，'%s'已存在", name));
String code = request.getCode();
CheckUtils.throwIf(() -> this.checkCodeExists(code, request.getId()), String.format("新增失败，'%s'已存在", code));
CheckUtils.throwIf(() -> this.checkCodeExists(code, null), String.format("新增失败，'%s'已存在", code));
// 新增信息
request.setStatus(DisEnableStatusEnum.ENABLE);
@@ -81,19 +81,18 @@ public class RoleServiceImpl extends BaseServiceImpl<RoleMapper, RoleDO, RoleVO,
@Override
@Transactional(rollbackFor = Exception.class)
public void update(RoleRequest request) {
public void update(RoleRequest request, Long id) {
String name = request.getName();
CheckUtils.throwIf(() -> this.checkNameExists(name, request.getId()), String.format("修改失败，'%s'已存在", name));
CheckUtils.throwIf(() -> this.checkNameExists(name, id), String.format("修改失败，'%s'已存在", name));
String code = request.getCode();
CheckUtils.throwIf(() -> this.checkCodeExists(code, request.getId()), String.format("修改失败，'%s'已存在", code));
CheckUtils.throwIf(() -> this.checkCodeExists(code, id), String.format("修改失败，'%s'已存在", code));
// 更新信息
super.update(request);
Long roleId = request.getId();
super.update(request, id);
// 保存角色和菜单关联
roleMenuService.save(request.getMenuIds(), roleId);
roleMenuService.save(request.getMenuIds(), id);
// 保存角色和部门关联
roleDeptService.save(request.getDeptIds(), roleId);
roleDeptService.save(request.getDeptIds(), id);
}
@Override

11
continew-admin-system/src/main/java/top/charles7c/cnadmin/system/service/impl/UserServiceImpl.java
View File

@@ -75,7 +75,7 @@ public class UserServiceImpl extends BaseServiceImpl<UserMapper, UserDO, UserVO,
@Transactional(rollbackFor = Exception.class)
public Long add(UserRequest request) {
String username = request.getUsername();
boolean isExists = this.checkNameExists(username, request.getId());
boolean isExists = this.checkNameExists(username, null);
CheckUtils.throwIf(() -> isExists, String.format("新增失败，'%s'已存在", username));
// 新增信息
@@ -91,16 +91,15 @@ public class UserServiceImpl extends BaseServiceImpl<UserMapper, UserDO, UserVO,
@Override
@Transactional(rollbackFor = Exception.class)
public void update(UserRequest request) {
public void update(UserRequest request, Long id) {
String username = request.getUsername();
boolean isExists = this.checkNameExists(username, request.getId());
boolean isExists = this.checkNameExists(username, id);
CheckUtils.throwIf(() -> isExists, String.format("修改失败，'%s'已存在", username));
// 更新信息
super.update(request);
Long userId = request.getId();
super.update(request, id);
// 保存用户和角色关联
userRoleService.save(request.getRoleIds(), userId);
userRoleService.save(request.getRoleIds(), id);
}
@Override