mirror of
				https://github.com/continew-org/continew-starter.git
				synced 2025-10-31 22:57:19 +08:00 
			
		
		
		
	refactor: 优化部分代码
修复 Sonar 扫描问题
This commit is contained in:
		| @@ -47,11 +47,13 @@ import top.charles7c.continew.starter.web.model.R; | ||||
| @RestControllerAdvice | ||||
| public class GlobalExceptionHandler { | ||||
|  | ||||
|     private static final String PARAM_FAILED = "请求地址 [{}],参数验证失败。"; | ||||
|  | ||||
|     /** | ||||
|      * 拦截自定义验证异常-错误请求 | ||||
|      */ | ||||
|     @ExceptionHandler(BadRequestException.class) | ||||
|     public R handleBadRequestException(BadRequestException e, HttpServletRequest request) { | ||||
|     public R<Void> handleBadRequestException(BadRequestException e, HttpServletRequest request) { | ||||
|         log.warn("请求地址 [{}],自定义验证失败。", request.getRequestURI(), e); | ||||
|         return R.fail(HttpStatus.BAD_REQUEST.value(), e.getMessage()); | ||||
|     } | ||||
| @@ -60,8 +62,8 @@ public class GlobalExceptionHandler { | ||||
|      * 拦截校验异常-违反约束异常 | ||||
|      */ | ||||
|     @ExceptionHandler(ConstraintViolationException.class) | ||||
|     public R constraintViolationException(ConstraintViolationException e, HttpServletRequest request) { | ||||
|         log.warn("请求地址 [{}],参数验证失败。", request.getRequestURI(), e); | ||||
|     public R<Void> constraintViolationException(ConstraintViolationException e, HttpServletRequest request) { | ||||
|         log.warn(PARAM_FAILED, request.getRequestURI(), e); | ||||
|         String errorMsg = CollUtil.join(e | ||||
|             .getConstraintViolations(), StringConstants.CHINESE_COMMA, ConstraintViolation::getMessage); | ||||
|         return R.fail(HttpStatus.BAD_REQUEST.value(), errorMsg); | ||||
| @@ -71,8 +73,8 @@ public class GlobalExceptionHandler { | ||||
|      * 拦截校验异常-绑定异常 | ||||
|      */ | ||||
|     @ExceptionHandler(BindException.class) | ||||
|     public R handleBindException(BindException e, HttpServletRequest request) { | ||||
|         log.warn("请求地址 [{}],参数验证失败。", request.getRequestURI(), e); | ||||
|     public R<Void> handleBindException(BindException e, HttpServletRequest request) { | ||||
|         log.warn(PARAM_FAILED, request.getRequestURI(), e); | ||||
|         String errorMsg = CollUtil.join(e | ||||
|             .getAllErrors(), StringConstants.CHINESE_COMMA, DefaultMessageSourceResolvable::getDefaultMessage); | ||||
|         return R.fail(HttpStatus.BAD_REQUEST.value(), errorMsg); | ||||
| @@ -82,8 +84,9 @@ public class GlobalExceptionHandler { | ||||
|      * 拦截校验异常-方法参数无效异常 | ||||
|      */ | ||||
|     @ExceptionHandler(MethodArgumentNotValidException.class) | ||||
|     public R handleMethodArgumentNotValidException(MethodArgumentNotValidException e, HttpServletRequest request) { | ||||
|         log.warn("请求地址 [{}],参数验证失败。", request.getRequestURI(), e); | ||||
|     public R<Void> handleMethodArgumentNotValidException(MethodArgumentNotValidException e, | ||||
|                                                          HttpServletRequest request) { | ||||
|         log.warn(PARAM_FAILED, request.getRequestURI(), e); | ||||
|         String errorMsg = CollUtil.join(e | ||||
|             .getAllErrors(), StringConstants.CHINESE_COMMA, DefaultMessageSourceResolvable::getDefaultMessage); | ||||
|         return R.fail(HttpStatus.BAD_REQUEST.value(), errorMsg); | ||||
| @@ -93,8 +96,8 @@ public class GlobalExceptionHandler { | ||||
|      * 拦截校验异常-方法参数类型不匹配异常 | ||||
|      */ | ||||
|     @ExceptionHandler(MethodArgumentTypeMismatchException.class) | ||||
|     public R handleMethodArgumentTypeMismatchException(MethodArgumentTypeMismatchException e, | ||||
|                                                        HttpServletRequest request) { | ||||
|     public R<Void> handleMethodArgumentTypeMismatchException(MethodArgumentTypeMismatchException e, | ||||
|                                                              HttpServletRequest request) { | ||||
|         String errorMsg = StrUtil.format("参数名:[{}],期望参数类型:[{}]", e.getName(), e.getParameter().getParameterType()); | ||||
|         log.warn("请求地址 [{}],参数转换失败,{}。", request.getRequestURI(), errorMsg, e); | ||||
|         return R.fail(HttpStatus.BAD_REQUEST.value(), errorMsg); | ||||
| @@ -104,7 +107,7 @@ public class GlobalExceptionHandler { | ||||
|      * 拦截文件上传异常-超过上传大小限制 | ||||
|      */ | ||||
|     @ExceptionHandler(MaxUploadSizeExceededException.class) | ||||
|     public R handleMaxUploadSizeExceededException(MaxUploadSizeExceededException e, HttpServletRequest request) { | ||||
|     public R<Void> handleMaxUploadSizeExceededException(MaxUploadSizeExceededException e, HttpServletRequest request) { | ||||
|         log.warn("请求地址 [{}],上传文件失败,文件大小超过限制。", request.getRequestURI(), e); | ||||
|         String sizeLimit = StrUtil.subBetween(e.getMessage(), "The maximum size ", " for"); | ||||
|         String errorMsg = String.format("请上传小于 %sMB 的文件", NumberUtil.parseLong(sizeLimit) / 1024 / 1024); | ||||
| @@ -115,7 +118,8 @@ public class GlobalExceptionHandler { | ||||
|      * 拦截校验异常-请求方式不支持异常 | ||||
|      */ | ||||
|     @ExceptionHandler(HttpRequestMethodNotSupportedException.class) | ||||
|     public R handleHttpRequestMethodNotSupported(HttpRequestMethodNotSupportedException e, HttpServletRequest request) { | ||||
|     public R<Void> handleHttpRequestMethodNotSupported(HttpRequestMethodNotSupportedException e, | ||||
|                                                        HttpServletRequest request) { | ||||
|         log.error("请求地址 [{}],不支持 [{}] 请求。", request.getRequestURI(), e.getMethod()); | ||||
|         return R.fail(HttpStatus.METHOD_NOT_ALLOWED.value(), e.getMessage()); | ||||
|     } | ||||
| @@ -124,7 +128,7 @@ public class GlobalExceptionHandler { | ||||
|      * 拦截业务异常 | ||||
|      */ | ||||
|     @ExceptionHandler(BusinessException.class) | ||||
|     public R handleServiceException(BusinessException e, HttpServletRequest request) { | ||||
|     public R<Void> handleServiceException(BusinessException e, HttpServletRequest request) { | ||||
|         log.error("请求地址 [{}],发生业务异常。", request.getRequestURI(), e); | ||||
|         return R.fail(HttpStatus.INTERNAL_SERVER_ERROR.value(), e.getMessage()); | ||||
|     } | ||||
| @@ -133,7 +137,7 @@ public class GlobalExceptionHandler { | ||||
|      * 拦截未知的运行时异常 | ||||
|      */ | ||||
|     @ExceptionHandler(RuntimeException.class) | ||||
|     public R handleRuntimeException(RuntimeException e, HttpServletRequest request) { | ||||
|     public R<Void> handleRuntimeException(RuntimeException e, HttpServletRequest request) { | ||||
|         log.error("请求地址 [{}],发生系统异常。", request.getRequestURI(), e); | ||||
|         return R.fail(e.getMessage()); | ||||
|     } | ||||
| @@ -142,7 +146,7 @@ public class GlobalExceptionHandler { | ||||
|      * 拦截未知的系统异常 | ||||
|      */ | ||||
|     @ExceptionHandler(Throwable.class) | ||||
|     public R handleException(Throwable e, HttpServletRequest request) { | ||||
|     public R<Void> handleException(Throwable e, HttpServletRequest request) { | ||||
|         log.error("请求地址 [{}],发生未知异常。", request.getRequestURI(), e); | ||||
|         return R.fail(e.getMessage()); | ||||
|     } | ||||
|   | ||||
		Reference in New Issue
	
	Block a user